Strings protection againt max_input_vars limit#276
Closed
Valc wants to merge 11 commits intojoomla-projects:developfrom
Closed
Strings protection againt max_input_vars limit#276Valc wants to merge 11 commits intojoomla-projects:developfrom
Valc wants to merge 11 commits intojoomla-projects:developfrom
Conversation
Updating to valc-keys chages
…se into joomla-projects-develop Conflicts: component/admin/models/translations.php
Update from source
keys filters update from main dev
Update from source
Update from source
Update from source
Contributor
Author
|
Another option is handle this one previously to allow the installation of com_localise, with code like this at the 'install.php' file. Here a draft to improve: |
Contributor
|
I prefer the original code in the PR as users may not have to deal with very long ini files (for 3rd party extensions for example). It has one issue though: Also: the item checked is the xx-XX file and not the reference one. I think both should be checked. |
Merged
Contributor
|
Found a way to get the right variables. Will make a new PR when ready. |
Contributor
|
O have made a new PR here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, :)
Whereas another solution that allows to edit language files without having to send all the strings is implemented, this idea can avoid losing data with large language files edition in this moment.
It is a basic comparation between the the php limit and the total strings in each file but can to be finetuned with the real counter of vars posted by form within language file edition (no idea about how many more are used as default).
Only is showing the idea, it have required Jtext and nice message.
Here the output setting the limit to 100:
Regards.